Don't add write only fields for tgc#16332
Merged
zli82016 merged 2 commits intoGoogleCloudPlatform:mainfrom Feb 10, 2026
Merged
Conversation
zli82016
force-pushed
the
tgc-fix-unit-test
branch
4 times, most recently
from
621bd11 to
f97d32a
Compare
zli82016
force-pushed
the
tgc-fix-unit-test
branch
from
f97d32a to
e57ba91
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
melinath
requested changes
Feb 9, 2026
Member
melinath
left a comment
melinath
left a comment
There was a problem hiding this comment.
I think we should handle this with Compiler instead of adding a new ProviderName field that contains the same information.
Also, it would be good to change the code to set Compiler at load time instead of MMv1 provider instantiation, similar to #16217, to avoid problems later. (We should probably also only set compiler on the Product and always read if from there instead of duplicating it onto resources, if possible.)
zli82016
force-pushed
the
tgc-fix-unit-test
branch
2 times, most recently
from
2a74234 to
17f70a4
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
zli82016
force-pushed
the
tgc-fix-unit-test
branch
from
17f70a4 to
641403b
Compare
This comment was marked as outdated.
This comment was marked as outdated.
zli82016
force-pushed
the
tgc-fix-unit-test
branch
from
641403b to
e986e4e
Compare
zli82016
force-pushed
the
tgc-fix-unit-test
branch
from
e986e4e to
7b53e85
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Member
Author
|
/gcbrun |
Collaborator
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
melinath
approved these changes
Feb 10, 2026
Merged
via the queue into
GoogleCloudPlatform:main
with commit Feb 10, 2026
1ce4531
27 checks passed
This was referenced Feb 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Don't add write only fields for tgc, as the write only fields are not in input of tfplan2cai, tfplan json.
Release Note Template for Downstream PRs (will be copied)
See Write release notes for guidance.